Conversation
Julow
reviewed
Sep 30, 2025
Julow
left a comment
Julow
left a comment
Owner
There was a problem hiding this comment.
Awesome! Do you have examples of apps that send autofills that I can test ?
Contributor
Bitwarden is one. |
Contributor
Author
|
I used this test page with KeePassDX to quickly validate changes in Chrome and Firefox. |
Julow
reviewed
Oct 1, 2025
Julow
left a comment
Julow
left a comment
Owner
There was a problem hiding this comment.
Thanks! I could test with KeePassDX
# Conflicts: # build.gradle.kts # res/layout/keyboard.xml # srcs/juloo.keyboard2/Keyboard2.java
Contributor
Author
|
Sorry for taking so long with this, I kind of forgot the PR even existed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Android 11, Android allows keyboards to display autofill suggestions inline instead of trying to show a popup.
Based on some code in AnySoftKeyboard, this PR introduces support for that feature here.
To do so, I had to modify the default keyboard layout to include a scrollable view in which the components provided by the framework are displayed. I based this on the layout for the emoji pane, but I must admit that I'm not completely happy with the comparatively large number of additional layout bits the java code now needs to keep track of.
(I could have also tried to reimplement their behavior manually, but that seemed overly complicated).
If you have an idea for a better approach the layout and its handling could be modified to take, please suggest it. It has been quite a while since I wrote any android UI stuff without compose, so I'm almost certain I forgot about something.
I set an
android:backgroundon the wrapping layout element in an attempt to get keyboard background opacity to work, which seems to have been successful, but I only really tried it in the keyboard app and the browser, both of which have a single-color background, so if you have another app with a more colorful background to try this with, that would be appreciated.With that said, this implementation of the feature does seem to work quite well in the emulator.